Conversation
Collaborator
Author
|
If you want to create another branch to test it, please comment it and I change the merge branch |
Owner
|
Which is your issue main branch? |
Collaborator
Author
|
Owner
I am asking for the branch that you are developing this issue. I think this is a temporal branch. Or this is the branch for the issue? |
ZhengLinLei
requested changes
Nov 25, 2023
Owner
ZhengLinLei
left a comment
ZhengLinLei
left a comment
There was a problem hiding this comment.
Use SCSS instead of changing CSS
Collaborator
Author
Done |
Owner
|
Everything is ok, the change is going to be added. Continue developing it @achechi15 |
ZhengLinLei
approved these changes
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the first animation asked in #86. Please check if this implementation can be included in your plans, otherwise, I would like you to say it to me, in order to redo it.
Warning: please be aware you cannot call the function from the developer tools, so you have to include the function inside the code. In addition, the function have the duration as parameter (in miliseconds), the default is 1000ms.