[UDFS] Fix async paging IO wait handling without boolean literals#73
Closed
Copilot wants to merge 2 commits into
Closed
[UDFS] Fix async paging IO wait handling without boolean literals#73Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…p and write.cpp Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Find alternative implementation without boolean usage
[UDFS] Fix async paging IO wait handling without boolean literals
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paging IO code paths in
read.cppandwrite.cppcould incorrectly returnSTATUS_CANT_WAITor deadlock whenWaitwasFALSEon entry for an async paging IO request. The fix mirrors the canonical Windows FS driver pattern of settingIRP_CONTEXT_FLAG_WAITon the IrpContext and derivingWaitfrom it, rather than assigning a boolean literal.Changes
read.cpp: Added missing async paging IO guard before_SEH2_TRY— absent entirely before this change, meaningWaitcould remainFALSEthrough theif (!Wait)guard in the non-cached read path.write.cpp: ReplacedWait = TRUEin the existing paging IO guard withSetFlag+BooleanFlagOn, consistent with howWaitis initialized fromIrpContext->Flagsat function entry.SetFlagis the authoritative mutation;Waitis kept in sync by re-deriving it from the flag, matching the existing initialization pattern at line 125 (read.cpp) and line 79 (write.cpp).Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.