Skip to content

[UDFS] Fix driver load failure on Windows XP / POSReady 2009 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: udf-dev
Choose a base branch
from
Open

[UDFS] Fix driver load failure on Windows XP / POSReady 2009 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cffe655
refactoring
assorted Feb 2, 2026
a3305a9
UDFInsertPrefix
assorted Feb 14, 2026
49afeeb
Initial plan
Copilot Feb 21, 2026
286d75f
Fix UDFS loading on Windows Embedded POSReady 2009 (XP SP3)
Copilot Feb 21, 2026
678dcd4
Merge udf-dev and fix UDFS loading on Windows XP / POSReady 2009
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/filesystems/udfs/misc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ UDFProcessException(
}
else if ((ExceptionCode == STATUS_VERIFY_REQUIRED) &&
FlagOn(IrpContext->Flags, IRP_CONTEXT_FLAG_TOP_LEVEL) &&
KeAreAllApcsDisabled()) {
(KeGetCurrentIrql() >= APC_LEVEL)) {

ExceptionCode = UDFFsdPostRequest(IrpContext, Irp);
}
Expand Down
5 changes: 5 additions & 0 deletions drivers/filesystems/udfs/udffs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ typedef FILE_ID *PFILE_ID;
#undef MdlMappingNoExecute
#define MdlMappingNoExecute 0
#define NonPagedPoolNx NonPagedPool
// POOL_NX_ALLOCATION (0x200) is a Windows 8+ flag not recognized on XP-based
// systems. Passing it to ExInitialize*LookasideList would result in an invalid
// pool type on Windows XP / POSReady 2009.
#undef POOL_NX_ALLOCATION
#define POOL_NX_ALLOCATION 0
#endif

// #define NDEBUG
Expand Down
7 changes: 5 additions & 2 deletions drivers/filesystems/udfs/udfinit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,11 @@ DriverEntry(
FilterCallbacks.PreAcquireForSectionSynchronization = UDFFilterCallbackAcquireForCreateSection;

RC = FsRtlRegisterFileSystemFilterCallbacks(DriverObject, &FilterCallbacks);
if (!NT_SUCCESS(RC))
try_return(RC);
if (!NT_SUCCESS(RC)) {
// On Windows XP, this call may fail. Treat as non-fatal.
UDFPrint(("UDF: FsRtlRegisterFileSystemFilterCallbacks failed with %x, continuing\n", RC));
RC = STATUS_SUCCESS;
}

UDFPrint(("UDF: Create CD dev obj\n"));
if (!NT_SUCCESS(RC = UDFCreateFsDeviceObject(UDF_FS_NAME_CD,
Expand Down