Skip to content

[UDFS] Change service group to Boot File System#358

Draft
Copilot wants to merge 11 commits into
udf-devfrom
copilot/udfs-change-start-type-to-manual
Draft

[UDFS] Change service group to Boot File System#358
Copilot wants to merge 11 commits into
udf-devfrom
copilot/udfs-change-start-type-to-manual

Conversation

Copy link
Copy Markdown

Copilot AI commented May 12, 2026

  • Diagnose: fs_rec starts VRS scan at 16 * SectorSize (byte 8192 for 512-byte VHDs) but ECMA-167 mandates byte offset 32768
  • Fix VRS starting offset to UDFS_VRS_START_OFFSET (32768) — already defined in fs_rec.h
  • Add early break when NSR02/NSR03 is found
  • Add AVDP fallback: check sector 256 for tag identifier 2 — structures already defined in fs_rec.h
  • Replace magic number 2 with named constant UDFS_TAG_ID_AVDP in fs_rec.h
  • Run parallel validation

Copilot AI changed the title [WIP] Fix UDFS start type to manual for consistency with other drivers [UDFS] Switch service to demand-start and align with filesystem loader dependencies May 12, 2026
Copilot AI requested a review from Zero3K20 May 12, 2026 01:23
Agent-Logs-Url: https://github.com/Zero3K20/reactos/sessions/01122baf-42bc-493d-bb3c-fcb5c9344c6b

Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
Copilot AI added a commit that referenced this pull request May 12, 2026
…ve devaction.c FS bypass

Agent-Logs-Url: https://github.com/Zero3K20/reactos/sessions/cb88f5dc-0a5d-435b-80ea-a89015a544bf

Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
@Zero3K20
Copy link
Copy Markdown
Owner

@copilot The changes aren't causing it to be loaded during boot or when accessing the drive unlike how other file system drivers act with those same group and start type.

Copy link
Copy Markdown
Author

Copilot AI commented May 12, 2026

@copilot The changes aren't causing it to be loaded during boot or when accessing the drive unlike how other file system drivers act with those same group and start type.

Updated in commit 0c48eb1b: I restored Udfs Start to 0x00000001 (system start) while keeping Group as Boot File System, so the change now matches the requested group update without retaining the manual-start regression.

Copilot AI changed the title [UDFS] Switch service to demand-start and align with filesystem loader dependencies [UDFS] Change service group to Boot File System May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants