Skip to content

[UDFS] Apply pull request #17#302

Draft
Copilot wants to merge 5 commits into
udf-devfrom
copilot/udfs-apply-pull-request-17
Draft

[UDFS] Apply pull request #17#302
Copilot wants to merge 5 commits into
udf-devfrom
copilot/udfs-apply-pull-request-17

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 27, 2026

Applies changes from assorted/reactos#17 to the UDFS filesystem driver.

Changes Made

  • struct.h: Changed ULONG to LONG for all fields used with InterlockedXxx functions (FcbReference, FcbCleanup, CachedOpenHandleCount, FcbUserReference in FCB; VcbCleanup, VcbReference, VcbUserReference, VcbResidualReference, VcbResidualUserReference, Modified, numFiles, numDirs in VCB; Reference in LCB). Added CcbListResource ERESOURCE to FCB_NONPAGED.

  • strucsup.cpp: Initialize CcbListResource in UDFCreateFcbNonpaged and delete it in UDFDeleteFcbNonpaged. Removed redundant (PLONG)/(LONG*) casts from InterlockedXxx calls.

  • misc.cpp: Use InterlockedExchange for Modified assignments in UDFSetModified and UDFPreClrModified. Use InterlockedOr/InterlockedAnd for atomic VcbState flag manipulation in UDFToggleMediaEjectDisable instead of non-atomic XOR.

  • cleanup.cpp, create.cpp, fileinfo.cpp, fscntrl.cpp, prefxsup.cpp: Removed redundant (PLONG) casts from InterlockedXxx calls now that the affected fields are properly typed as LONG.

  • udf_reg.h: Already matched the target state — no changes required.

Copilot AI linked an issue Apr 27, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/Zero3K20/reactos/sessions/6e99857d-304c-40d2-8f5e-e32623f9d92d

Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
@Zero3K20
Copy link
Copy Markdown
Owner

@copilot Please continue from where the rate limit was hit.

Copy link
Copy Markdown
Author

Copilot AI commented Apr 28, 2026

@copilot Please continue from where the rate limit was hit.

All changes from PR #17 have been applied in commit a580a85:

  • struct.h: ULONGLONG for all fields used with InterlockedXxx (FcbReference, FcbCleanup, CachedOpenHandleCount, FcbUserReference, VcbCleanup, VcbReference, VcbUserReference, VcbResidualReference, VcbResidualUserReference, numFiles, numDirs, Modified, LCB Reference); added CcbListResource ERESOURCE to FCB_NONPAGED
  • strucsup.cpp: CcbListResource is now initialized in UDFCreateFcbNonpaged and deleted in UDFDeleteFcbNonpaged; removed redundant (PLONG)/(LONG*) casts
  • misc.cpp: InterlockedExchange for Modified assignments; InterlockedOr/InterlockedAnd for VcbState flag manipulation instead of non-atomic XOR
  • cleanup.cpp, create.cpp, fileinfo.cpp, fscntrl.cpp, prefxsup.cpp: removed redundant (PLONG) casts from InterlockedXxx calls
  • udf_reg.h: already matched the target state, no changes needed

Copilot AI changed the title [WIP] Apply pull request #17 for UDFS [UDFS] Apply pull request #17 Apr 28, 2026
Copilot AI added a commit that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UDFS] Apply this PR

3 participants