🧪 Add edge case tests for version comparisons in dl_cleanup.py#99
🧪 Add edge case tests for version comparisons in dl_cleanup.py#99ManupaKDU wants to merge 2 commits into
Conversation
Adds unittests in `scripts/test_dl_cleanup.py` to cover the `__ge__` method of the `Entry` class, properly validating edge cases for different version string formats to prevent logic regressions. Signed-off-by: Jules <jules@example.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds unittests in `scripts/test_dl_cleanup.py` to cover the `__ge__` method of the `Entry` class, properly validating edge cases for different version string formats to prevent logic regressions. Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
1 participant
🎯 What: The
__ge__method inscripts/dl_cleanup.py'sEntryclass was pure logic without any test coverage. This PR introduces a dedicated test suite to ensure its correctness.📊 Coverage: Scenarios covered include standard 4-part versions (1.2.3.4), missing patch numbers/letters (1.2.3a vs 1.2.3), equal versions, and mixed format comparisons.
✨ Result: Test coverage for the core script comparison logic is now established, enabling safe future refactoring.
Signed-off-by: Jules jules@example.com
PR created automatically by Jules for task 12758481474209516926 started by @manupawickramasinghe