🎨 Palette: [UX improvement] Improve foreground service notification UX#119
🎨 Palette: [UX improvement] Improve foreground service notification UX#119manupawickramasinghe wants to merge 1 commit into
Conversation
đź’ˇ What: Extracted hardcoded foreground service notification strings to localized string resources. Replaced the technical `CHANNEL_ID` and "RemoteCam run" with human-readable "Remote Camera Service" and a clear description. Changed the action button from the aggressive "Kill" to "Stop", and updated the text from "Click to open" to "Tap to open".
🎯 Why: System notification channels are exposed to the user in Android settings; using technical IDs looks unprofessional. Furthermore, standard mobile UX dictates using touch-appropriate terminology ("Tap" over "Click") and non-aggressive actions ("Stop" over "Kill").
📸 Before/After: N/A (Foreground service notification text)
♿ Accessibility: Ensures all notification channel properties, titles, text, and actions are fully localizable via string resources, supporting internationalization.
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
đź‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a đź‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves the Android foreground service notification UX by moving user-facing notification/channel strings into localized resources and updating the foreground service to display friendlier copy in system UI (notification shade + notification channel settings).
Changes:
- Added string resources for foreground service notification channel name/description and notification title/text/action label.
- Updated
Camforeground service notification/channel creation to use the new localized resources and “Stop” action label. - Logged the UX/accessibility learnings in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds localized string resources for foreground service notification/channel UI text. |
| app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt | Uses string resources for NotificationChannel + foreground notification title/text/action label. |
| .Jules/palette.md | Documents the rationale/learning for avoiding technical identifiers and aggressive UI copy. |
đź’ˇ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| val channel = NotificationChannel( | ||
| CHANNEL_ID, | ||
| CHANNEL_ID, | ||
| getString(R.string.notification_channel_name), | ||
| NotificationManager.IMPORTANCE_DEFAULT | ||
| ) | ||
| channel.description = "RemoteCam run" | ||
| channel.description = getString(R.string.notification_channel_desc) | ||
| val notificationManager = getSystemService(NotificationManager::class.java) | ||
| notificationManager.createNotificationChannel(channel) |
| .setContentTitle(getString(R.string.notification_title)) | ||
| .setContentText(getString(R.string.notification_text)).setOngoing(true) | ||
| .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop),pendingIntentKill) |
đź’ˇ What: Extracted hardcoded foreground service notification strings to localized string resources. Replaced the technical
CHANNEL_IDand "RemoteCam run" with human-readable "Remote Camera Service" and a clear description. Changed the action button from the aggressive "Kill" to "Stop", and updated the text from "Click to open" to "Tap to open".🎯 Why: System notification channels are exposed to the user in Android settings; using technical IDs looks unprofessional. Furthermore, standard mobile UX dictates using touch-appropriate terminology ("Tap" over "Click") and non-aggressive actions ("Stop" over "Kill").
📸 Before/After: N/A (Foreground service notification text)
♿ Accessibility: Ensures all notification channel properties, titles, text, and actions are fully localizable via string resources, supporting internationalization.
PR created automatically by Jules for task 16276830243435790675 started by @manupawickramasinghe