Skip to content

🎨 Palette: Localize Foreground Service Notification Text#118

Open
manupawickramasinghe wants to merge 2 commits into
mainfrom
palette/localize-foreground-notification-1574374644286751812
Open

🎨 Palette: Localize Foreground Service Notification Text#118
manupawickramasinghe wants to merge 2 commits into
mainfrom
palette/localize-foreground-notification-1574374644286751812

Conversation

@manupawickramasinghe
Copy link
Copy Markdown
Member

💡 What: Extracted hardcoded foreground service notification strings (channel names, descriptions, titles, action buttons) into localized string resources (strings.xml) and updated terminology.
🎯 Why: Hardcoding notification strings circumvents localization systems and exposes untranslated, potentially technical text to the user. Using harsh phrasing like "Kill" for user-facing actions or desktop-centric terms like "Click" is a poor UX practice compared to standard terminology like "Stop" and "Tap".
📸 Before/After:
Before: RemoteCam (active) / Click to open / Action: Kill (Hardcoded)
After: @string/notification_title / @string/notification_text ("Tap to open") / Action: @string/notification_action_stop ("Stop")
♿ Accessibility: Ensures that notification text, including channel names exposed in Android system settings, can be properly translated and read with localized context by screen readers.


PR created automatically by Jules for task 1574374644286751812 started by @manupawickramasinghe

- Added localized strings for notification channel name, description, title, text, and action label.
- Replaced hardcoded technical and aggressive terminology (e.g. "Kill", "Click to open") with standard mobile UX phrasing (e.g. "Stop", "Tap to open").
- Updated Cam.kt to use getString() for referencing the new string resources.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings May 24, 2026 20:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

- Added localized strings for notification channel name, description, title, text, and action label.
- Replaced hardcoded technical and aggressive terminology (e.g. "Kill", "Click to open") with standard mobile UX phrasing (e.g. "Stop", "Tap to open").
- Updated Cam.kt to use getString() for referencing the new string resources.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants