feat: Homebridge 2 readiness#159
Open
joshjohanning wants to merge 3 commits into
Open
Conversation
- engines.node: ^22.12.0 || ^24.0.0 (matches Homebridge v2 requirement) - engines.homebridge: ^1.6.0 || ^2.0.0 (dual compat) - devDependencies: homebridge ^2.0.2, typescript ^5.9.3, @types/node ^22
Homebridge v2 transitively pulls in @matter/* type definitions that fail under the project's existing 'node' moduleResolution. Skipping declaration file checks avoids the errors without altering the project's TypeScript resolution strategy.
…ic comparison controllerFirmwareVersion is typed as 'string | number'. TypeScript 5 rejects the '<=', '>', and '==' numeric comparisons used in the processRequest() power-command path. Narrow the value via Number() once and reuse it for all comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds compatibility with Homebridge v2 while keeping v1 support. Minimal, focused changes: dependency bumps, one tsconfig flag, and one type-narrowing fix.
closes #155