Fix XSS vulnerability when editing JSON - #81
Open
crimist wants to merge 1 commit into
Open
Conversation
|
@crimist is attempting to deploy a commit to the Suni's projects Team on Vercel. A member of the Team first needs to authorize it. |
crimist
marked this pull request as ready for review
August 11, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editable primitive values are currently passed to
dangerouslySetInnerHTML. A JSON string containing HTML is therefore parsed as DOM when edit mode is opened.Render the value as a React text child instead, preserving the existing
contentEditablebehavior while keeping HTML-like values inert.Vuln PoC
Here's a PoC against the demo website:
Payload:
{"a":"<img src=x onerror='alert()'>"}