SMBIOS memory slot ordering and naming and count tweaks to MacPro71#15
Closed
SMBIOS memory slot ordering and naming and count tweaks to MacPro71#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
PatchTableType16the code now detectsMacPro71and only then setsMemoryErrorCorrection = MemoryErrorCorrectionMultiBitEcc,MaximumCapacity = 0x60000000(1.5 TB in KB) andExtendedMaximumCapacity = 0, and it enforces a minimumNumberOfMemoryDevicesof 12 for MacPro71 only.GetTableType17the slotTypeis preserved from SMBIOS only forMacPro71so other models continue to use existing inference logic.PatchTableType17the previous broadisMacProflag is replaced byisOldMacProfor legacy MacPro models and MacPro71 gets isolated handling: channel mapping logic excludes MacPro71, MacPro71 getsTotalWidth = 72andDataWidth = 64, device/bank locator handling is adapted to prefer existing SMBIOS strings or fall back toDIMM<N>/BANK <n>, empty slots are set toMemoryTypeDdr4for MacPro71, and the expected slot count is clamped to at least 12 only for MacPro71.PatchSmbiostheSlotCountsused to size arrays is bumped to at least 12 only when the model isMacPro71so array sizing and subsequent logic do not affect other systems.Testing
masterbranch.GetModelFromString(...) == MacPro71checks to avoid impacting other models, and the user will validate on their MacPro71 hardware.Codex Task