Skip to content

SMBIOS memory slot ordering and naming and count tweaks to MacPro71#15

Closed
YBronst wants to merge 2 commits intomasterfrom
9ym2ne-codex/apply-macpro71-specific-memory-changes
Closed

SMBIOS memory slot ordering and naming and count tweaks to MacPro71#15
YBronst wants to merge 2 commits intomasterfrom
9ym2ne-codex/apply-macpro71-specific-memory-changes

Conversation

@YBronst
Copy link
Owner

@YBronst YBronst commented Feb 7, 2026

Motivation

  • Previous memory-related SMBIOS changes were applied too broadly and affected non-MacPro71 systems, so the intent is to limit those adjustments strictly to MacPro71.
  • Ensure MacPro71 reports correct memory characteristics (ECC, MaximumCapacity, slot counts and Type17 fields) without altering behavior for other Mac models or non‑Mac systems.

Description

  • In PatchTableType16 the code now detects MacPro71 and only then sets MemoryErrorCorrection = MemoryErrorCorrectionMultiBitEcc, MaximumCapacity = 0x60000000 (1.5 TB in KB) and ExtendedMaximumCapacity = 0, and it enforces a minimum NumberOfMemoryDevices of 12 for MacPro71 only.
  • In GetTableType17 the slot Type is preserved from SMBIOS only for MacPro71 so other models continue to use existing inference logic.
  • In PatchTableType17 the previous broad isMacPro flag is replaced by isOldMacPro for legacy MacPro models and MacPro71 gets isolated handling: channel mapping logic excludes MacPro71, MacPro71 gets TotalWidth = 72 and DataWidth = 64, device/bank locator handling is adapted to prefer existing SMBIOS strings or fall back to DIMM<N>/BANK <n>, empty slots are set to MemoryTypeDdr4 for MacPro71, and the expected slot count is clamped to at least 12 only for MacPro71.
  • In PatchSmbios the SlotCounts used to size arrays is bumped to at least 12 only when the model is MacPro71 so array sizing and subsequent logic do not affect other systems.

Testing

  • No automated tests were executed as requested; the change is limited to source edits and committed to the master branch.
  • The modifications are scoped by explicit GetModelFromString(...) == MacPro71 checks to avoid impacting other models, and the user will validate on their MacPro71 hardware.

Снимок экрана 2026-02-07 at 18 37 23
Снимок экрана 2026-02-07 at 18 38 54


Codex Task

@YBronst YBronst marked this pull request as ready for review February 7, 2026 18:50
@YBronst YBronst changed the title Scope SMBIOS memory tweaks to MacPro71 SMBIOS memory slot ordering and naming and count tweaks to MacPro71 Feb 7, 2026
@YBronst YBronst added the enhancement New feature or request label Feb 7, 2026
@YBronst YBronst deleted the branch master February 7, 2026 21:06
@YBronst YBronst closed this Feb 7, 2026
@YBronst YBronst deleted the 9ym2ne-codex/apply-macpro71-specific-memory-changes branch February 7, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant