extract shared x86-64 SIMD nonvolatile XMM save/restore includes#93
Merged
Conversation
Add SimdNonVolatileSave_x86_64.inc / SimdNonVolatileRestore_x86_64.inc (mirroring CryptoLib) and route every x86-64 SIMD kernel that clobbers xmm6..xmm15 through them (27 kernels: CRC, SHA1/256/512, SHA3/Keccak, Blake2, Blake3, Adler32, Argon2). The shared save is a fixed 160-byte, legacy-movups block guarded by HASHLIB_SYSV_X64_ABI, so it emits only on the Win64 ABI and is a no-op on Linux/macOS where xmm6..15 are volatile. Per kernel the nonvolatile XMM saves are pulled out of the combined stack frame into the shared block; each GPR/scratch frame is re-sized to reclaim the freed slots (no dead space) while keeping rsp 16-byte aligned, so existing aligned movdqa scratch access is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SimdNonVolatileSave_x86_64.inc / SimdNonVolatileRestore_x86_64.inc (mirroring CryptoLib) and route every x86-64 SIMD kernel that clobbers xmm6..xmm15 through them (27 kernels: CRC, SHA1/256/512, SHA3/Keccak, Blake2, Blake3, Adler32, Argon2).
The shared save is a fixed 160-byte, legacy-movups block guarded by HASHLIB_SYSV_X64_ABI, so it emits only on the Win64 ABI and is a no-op on Linux/macOS where xmm6..15 are volatile. Per kernel the nonvolatile XMM saves are pulled out of the combined stack frame into the shared block; each GPR/scratch frame is re-sized to reclaim the freed slots (no dead space) while keeping rsp 16-byte aligned, so existing aligned movdqa scratch access is preserved.