refactor: move dynamic import resolution to unit initialization#63
Merged
refactor: move dynamic import resolution to unit initialization#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move dynamic library symbol resolution (
dlopen/dlsym) from lazyper-call resolution to one-time unit initialization for ARM hardware
capability detection on Linux, Android, BSD, and macOS (Darwin).
Changes
HlpArmHwCapProvider.pas (Linux/Android and BSD)
ResolveOncetoResolveDynamicImportsand removed themanual
FResolvedboolean guard, since the initialization sectionguarantees single execution.
ResolveOncecalls fromGetHwCapandGetHwCap2— thefunction pointers are already resolved by the time any caller can
reach them.
initializationsection that callsResolveDynamicImportsat unit load time.strict privatetoprivateso theinitialization section can access the method.
HlpDarwinSysCtl.pas (macOS/iOS)
ResolveOncetoResolveDynamicImports,removed the
FResolvedguard, removed the call fromHasFeature,and moved resolution to an
initializationsection.Rationale
The previous pattern resolved imports lazily on first use with a
boolean guard. This worked but added a branch to every call of
GetHwCap,GetHwCap2, andHasFeature. Since these functionpointers never change after resolution, performing the
dlopen/dlsymonce at unit initialization is simpler, removes the redundant flag
field, and eliminates repeated nil-check overhead on the hot path.