Merged
Conversation
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
HimanshuChoudhary-Xilinx
requested review from
rozumx and
stsoe
as code owners
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the aiebu submodule build for edge devices by removing the conditional exclusion previously in place.
Changes:
- Simplified CMake build logic to allow aiebu compilation on edge platforms
- Added dtrace library directory to the edge build package configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/runtime_src/core/common/CMakeLists.txt | Removed XRT_EDGE conditional check that previously disabled aiebu build for edge devices |
| build/build_edge.sh | Added dtrace library directory to package file list for edge builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -13,7 +13,7 @@ if(CMAKE_VERSION VERSION_LESS "3.18.0") | |||
| message(WARNING "CMake version is less than 3.18.0, build of submodule aiebu disabled") | |||
There was a problem hiding this comment.
The simplified conditional structure now allows aiebu to build on ARM64 platforms when it was previously disabled. Consider adding a comment explaining why the ARM64 restriction from line 14-15 is still necessary while edge device restrictions have been removed.
Suggested change
| message(WARNING "CMake version is less than 3.18.0, build of submodule aiebu disabled") | |
| message(WARNING "CMake version is less than 3.18.0, build of submodule aiebu disabled") | |
| # ARM64 builds of aiebu remain disabled intentionally (e.g. due to current | |
| # lack of support / known issues), even though earlier edge-device-specific | |
| # restrictions have been removed. Update this condition only when ARM64 | |
| # support for aiebu is fully validated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR enables the aiebu submodule build for edge devices.
Changes:
Simplified CMake build logic to allow aiebu compilation on edge platforms
Added dtrace library directory to the edge build package configuration
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)