ci: test the Ruby event source - #385
Open
ryanduguid wants to merge 2 commits into
Open
Conversation
ryanduguid
marked this pull request as ready for review
August 14, 2026 10:28
…oor gap The pin comment claimed v4.2.2, but 11d5960a326750d5838078e36cf38b85af677262 is tag v4.4.0. Verified with `gh api repos/actions/checkout/git/ref/tags/v4.2.2`, which resolves to 11bd71901bbe5b1630ceea73d27597364c9af683, and with `gh api repos/actions/checkout/commits/11d5960a...`, which is the v4.4.0 "backport fixes to releases-v4" commit dated 2026-07-16. Corrected the comment rather than repinning to v4.2.2: the pinned SHA is the newer release, so repinning down would drop roughly 21 months of fixes to keep a stale comment true. The ruby/setup-ruby pin was checked the same way and its v1.321.0 comment is correct. Also recorded the Ruby floor dependency in the matrix. The matrix starts at 3.2 while xero-ruby.gemspec still declares required_ruby_version ">= 2.3", so on its own this workflow ships a gem advertising 2.3 through 3.1 with no CI coverage there. PR XeroAPI#387 raises the gemspec floor and should land with or before this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XeroAPI/xero-rubyon every pull requestValidation
actionlint .github/workflows/build-test-lint.ymllib/andspec/with Ruby 3.2.11git diff --checkThe full dependency-backed matrix is intentionally delegated to this pull request's exact-head GitHub Actions checks because native Windows gems require MSYS2, which is unavailable in the local portable Ruby environment. Until those hosted checks run, Ruby 3.2 Windows support is unverified rather than passing.