fix: redact sensitive API error headers - #817
Open
ryanduguid wants to merge 3 commits into
Open
Conversation
ryanduguid
marked this pull request as draft
August 12, 2026 17:49
ryanduguid
marked this pull request as ready for review
August 18, 2026 15:06
tokenRequest() and queryApi() rejected the raw AxiosError, bypassing the ApiError redactor entirely. AxiosError.toJSON() serialises error.config, so a caller doing JSON.stringify(err) recovered the Basic base64(clientId: clientSecret) header and the refresh_token body from the token request, and the Bearer access token from queryApi (which backs the public updateTenants()). Both catch blocks now build an ApiError and reject the redacted, serialised result, matching the pattern already used by every generated API client. Adds nock-driven integration tests that fail against the unfixed client, covering both paths with real axios failures rather than object literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiErrorAccept, request IDs, content type, and rate-limit metadataThis is intentionally additive to the currently open error-object work (#812 / #816): whichever error representation is adopted should not expose request credentials or response cookies.
Validation
npm test -- --runInBand src/test/apiError.spec.tsnpm test -- --runInBandnpm run buildgit diff --check