Skip to content

Exclude macOS process lookup from iOS#6524

Open
yiguodev wants to merge 1 commit into
XTLS:mainfrom
OneXray:fix/macos-process-ios-build
Open

Exclude macOS process lookup from iOS#6524
yiguodev wants to merge 1 commit into
XTLS:mainfrom
OneXray:fix/macos-process-ios-build

Conversation

@yiguodev

Copy link
Copy Markdown
Collaborator

Summary

  • restrict the Darwin libproc process lookup implementation to macOS
  • add an iOS fallback that reports process lookup as unsupported
  • keep macOS process-based routing behavior unchanged

Why

Go's darwin build constraint also matches GOOS=ios. As a result, the macOS implementation imported proc_pidinfo, proc_pidfdinfo, and proc_pidpath into iOS binaries even though these APIs are not exposed through the public iOS SDK. This can trigger App Store Guideline 2.5.1 validation or review failures.

Validation

  • go test ./common/net -count=1
  • CGO_ENABLED=0 go test ./common/net -count=1
  • go test ./app/router ./proxy/tun -count=1
  • verified GOOS=ios selects find_process_ios.go
  • verified the iOS archive contains no proc_pid* symbols while the macOS archive still does

@RPRX

RPRX commented Jul 20, 2026

Copy link
Copy Markdown
Member

路由 process for Linux 对于 TUN 入站也兼容一下吧,你测测

@yiguodev
yiguodev marked this pull request as ready for review July 20, 2026 04:05
Copilot AI review requested due to automatic review settings July 20, 2026 04:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants