817: Add configurability to range question type#832
Open
lindsay-stevens wants to merge 1 commit intoXLSForm:masterfrom
Open
817: Add configurability to range question type#832lindsay-stevens wants to merge 1 commit intoXLSForm:masterfrom
lindsay-stevens wants to merge 1 commit intoXLSForm:masterfrom
Conversation
2aadc2b to
0369cdb
Compare
0369cdb to
4f6fe56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #817
Why is this the best possible solution? Were any other approaches considered?
Follows the specification in the linked ticket, related spec ticket, and forum post.
I was not completely clear on the discussion around asc/desc range support but there is a test
test_range_spec_patterns__okto show these variants that pass without error, even though half of them would potentially produce an empty range.What are the regression risks?
The parameters are validated more closely now so that could cause an error where there was none before, but the added errors are intended to be consistent with what Collect and/or Webforms support anyway.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes, though there are already filed: getodk/docs#2031 getodk/xforms-spec#336
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code