Bundler output#51
Merged
Merged
Conversation
does not use wasm-pack, to avoid having to upstream changes and the dependency on wasm-split. The correct wasm-bindgen version is figured out automatically, similar to how it is done in the test-runner. the internal testing of the generated webpack module is not contained
this is (unsurprisingly) a lot more fiddly on javascript side. We need: import.source, since we can't rely on `fetch` in node.
previously would always succeed after loading, no matter the function behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables a webpack compatible output. For now, this depends on two experimental options in webpack,
asyncWebAssemblyandsourceImport.asyncWebAssemblycan most likely be replaced withsyncWebAssemblyon some downstream configurations and is not as required as this comment makes it seem.sourceImportis wired into the javascript emitted fromjs.rsthough in the__wasm_split.jsfile. Other syntax there should be possible, butfetchis not supported in node environments, so this is the only way I can see to load but not instantiate a wasm module for now.Partially resolves #4, other environments such as bun or simple node/commonjs are not in this PR.