Skip to content

Emit valid values for aria-pressed on the Customizer device buttons #13046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westonruter wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −12
Open

Emit valid values for aria-pressed on the Customizer device buttons #13046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/customize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
$class .= ' active';
}
?>
<button type="button" class="<?php echo esc_attr( $class ); ?>" aria-pressed="<?php echo esc_attr( $active ); ?>" data-device="<?php echo esc_attr( $device ); ?>">
<button type="button" class="<?php echo esc_attr( $class ); ?>" aria-pressed="<?php echo $active ? 'true' : 'false'; ?>" data-device="<?php echo esc_attr( $device ); ?>">
<span class="devices__preview-label"><?php echo esc_html( $settings['label'] ); ?></span>
</button>
<?php endforeach; ?>
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class="<?php echo esc_attr( $classes_for_button ); ?>"
data-choose-text="<?php esc_attr_e( 'Choose a Site Icon' ); ?>"
data-update-text="<?php esc_attr_e( 'Change Site Icon' ); ?>"
data-update="<?php esc_attr_e( 'Set as Site Icon' ); ?>"
data-state="<?php echo esc_attr( has_site_icon() ); ?>"
data-state="<?php echo has_site_icon() ? '1' : ''; ?>"

>
<?php if ( has_site_icon() ) : ?>
Expand Down
10 changes: 0 additions & 10 deletions tests/phpstan/baselines/argument.type.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ parameters:
identifier: argument.type
count: 2
path: ../../../src/wp-admin/comment.php
-
message: '#^Parameter \#1 \$text of function esc_attr expects float\|int\|string, bool given\.$#'
identifier: argument.type
count: 1
path: ../../../src/wp-admin/customize.php
-
message: '#^Parameter \#1 \$position of function wp_comment_reply expects int, string given\.$#'
identifier: argument.type
Expand Down Expand Up @@ -448,11 +443,6 @@ parameters:
identifier: argument.type
count: 1
path: ../../../src/wp-admin/network/site-users.php
-
message: '#^Parameter \#1 \$text of function esc_attr expects float\|int\|string, bool given\.$#'
identifier: argument.type
count: 1
path: ../../../src/wp-admin/options-general.php
-
message: '#^Parameter \#2 \$callback of function array_filter expects \(callable\(mixed\)\: bool\)\|null, ''validate_file'' given\.$#'
identifier: argument.type
Expand Down
Loading