Skip to content

REST API: Remove a redundant private property in WP_REST_Template_Autosaves_Controller. #13041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CallumBW95 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −37
Open

REST API: Remove a redundant private property in WP_REST_Template_Autosaves_Controller. #13041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ includes:
- tests/phpstan/baselines/property.defaultValue.neon
- tests/phpstan/baselines/property.nonObject.neon
- tests/phpstan/baselines/property.notFound.neon
- tests/phpstan/baselines/property.onlyWritten.neon
- tests/phpstan/baselines/property.phpDocType.neon
- tests/phpstan/baselines/property.private.neon
- tests/phpstan/baselines/property.protected.neon
Expand Down
13 changes: 2 additions & 11 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-template-autosaves-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@
* @see WP_REST_Autosaves_Controller
*/
class WP_REST_Template_Autosaves_Controller extends WP_REST_Autosaves_Controller {
/**
* Parent post type.
*
* @since 6.4.0
* @var string
*/
private $parent_post_type;

/**
* Parent post controller.
*
Expand Down Expand Up @@ -56,9 +48,8 @@ class WP_REST_Template_Autosaves_Controller extends WP_REST_Autosaves_Controller
*/
public function __construct( $parent_post_type ) {
parent::__construct( $parent_post_type );
$this->parent_post_type = $parent_post_type;
$post_type_object = get_post_type_object( $parent_post_type );
$parent_controller = $post_type_object->get_rest_controller();
$post_type_object = get_post_type_object( $parent_post_type );
$parent_controller = $post_type_object->get_rest_controller();

if ( ! $parent_controller ) {
$parent_controller = new WP_REST_Templates_Controller( $parent_post_type );
Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/property.onlyWritten.neon
View file
Open in desktop

This file was deleted.

Loading