General: Align wp_is_stream() with PHP's stream wrapper matching - #13038
General: Align wp_is_stream() with PHP's stream wrapper matching#13038itzmekhokan wants to merge 1 commit into
Conversation
PHP resolves a scheme by looking it up as given, then retrying once with the scheme lowercased. wp_is_stream() only performed the exact match, so paths such as `FILE:///path/to/file` were reported as non-streams even though PHP reads them. Match the scheme as given, then fall back to a lowercased lookup. The registered wrappers are not themselves lowercased, so a wrapper registered as `MyStream` remains unreachable as `mystream`, as in PHP. Fixes #65870.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
wp_is_stream()reportsfalsefor stream URLs whose scheme is not lowercase, such asFILE:///path/to/file, even though PHP opens and reads them without trouble.PHP resolves a scheme by looking it up in the registered wrappers as given, then retrying once with the scheme lowercased;
wp_is_stream()only did the exact match. The patch adds the same lowercased fallback. It deliberately does not lowercase the registered wrappers, so a wrapper registered asMyStreamstays unreachable asmystream, matching PHP.The accepted set only widens, so no path that returned
truebefore can now returnfalse.Trac ticket: https://core.trac.wordpress.org/ticket/65870
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Reviewing PHP's stream wrapper lookup, drafting the fix, and adding regression tests. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.