Skip to content

Tests: Clean up the wp_delete_post() unit tests #13036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soean wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −36
Open

Tests: Clean up the wp_delete_post() unit tests #13036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 4 additions & 36 deletions tests/phpunit/tests/post/wpDeletePost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,38 +16,6 @@
*/
class Tests_Post_WpDeletePost extends WP_UnitTestCase {

/**
* User IDs for the test.
*
* @var array{administrator: int, editor: int, contributor: int}
*/
protected static $user_ids;

/**
* Set up before class.
*
* @param WP_UnitTest_Factory $factory The Unit Test Factory.
*/
public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
self::$user_ids = array(
'administrator' => $factory->user->create(
array(
'role' => 'administrator',
)
),
'editor' => $factory->user->create(
array(
'role' => 'editor',
)
),
'contributor' => $factory->user->create(
array(
'role' => 'contributor',
)
),
);
}

/**
* Tests wp_delete_post reassign hierarchical post type.
*/
Expand Down Expand Up @@ -120,9 +88,9 @@ public function test_wp_delete_post_short_circuit_on_post_id_zero() {
}

/**
* Tests wp_delete_post() when the post for the post_id has been already deleted.
* Tests that wp_delete_post() returns null when the post has already been deleted.
*/
public function test_wp_delete_post_returns_false_for_invalid_post() {
public function test_wp_delete_post_returns_null_for_already_deleted_post() {
$post_id = self::factory()->post->create();
$deleted_post = wp_delete_post( $post_id, true );
$this->assertInstanceOf( WP_Post::class, $deleted_post );
Expand Down Expand Up @@ -163,7 +131,7 @@ static function () use ( $action, &$captured_action_args ) {
$deleted_post = wp_delete_post( (string) $post_id, true );
$this->assertInstanceOf( WP_Post::class, $deleted_post );

foreach ( array( 'before_delete_post', 'delete_post_post', 'delete_post', 'deleted_post_post', 'deleted_post', 'after_delete_post' ) as $action ) {
foreach ( $actions as $action ) {
$this->assertSame( $initial_action_counts[ $action ] + 1, did_action( $action ), "Expected $action action count to increment by 1." );
$this->assertCount( 2, $captured_action_args[ $action ], "Expected count for $action action" );
$this->assertSame( $post_id, $captured_action_args[ $action ][0], "Expected post ID for $action action" );
Expand All @@ -175,7 +143,7 @@ static function () use ( $action, &$captured_action_args ) {
/**
* Tests short-circuiting wp_delete_post() with pre_delete_post filter.
*
* @ticket @63975
* @ticket 63975
*/
public function test_wp_delete_post_can_be_short_circuited() {
$post_id = self::factory()->post->create();
Expand Down
Loading