Skip to content

Fix: Adminbar: Unnatural focus outline in frontend#11727

Open
hbhalodia wants to merge 1 commit intoWordPress:trunkfrom
hbhalodia:fix/issue-65177
Open

Fix: Adminbar: Unnatural focus outline in frontend#11727
hbhalodia wants to merge 1 commit intoWordPress:trunkfrom
hbhalodia:fix/issue-65177

Conversation

@hbhalodia
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65177

Description

  • Admin bar on wp-admin page was having outline set as 0, but on frontend the default outline was being shown which was having inconsistency with admin page admin bar.
  • PR aims to remove the outline from the frontend admin bar, which mimics exactly the admin bar on wp-admin side.

Screenshots

Before After
Screenshot 2026-05-06 at 10 24 41 AM Screenshot 2026-05-06 at 10 24 30 AM

Use of AI Tools

  • None

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. However, we cannot simply remove the outline because it is necessary in Windows High Contrast mode, as the text and background colors do not change when focused.

Image

You can test this issue by opening the developer tools in the Chrome browser, accessing "More Tools", "Rendering", and "Emulate CSS media feature forced-colors", and changing it to "forced-colors:active".

In WordPress, transparent outlines are sometimes used to solve this type of problem. This approach takes advantage of the characteristic that transparent outlines are not visually displayed, but they become visible in Windows High Contrast Mode.

Image

Based on this, it should be sufficient to simply make the following changes.

#wpadminbar a:focus {
	outline-offset: -1px;
	/* Only visible in Windows High Contrast mode */
	outline: 2px solid transparent;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants