Fix: Adminbar: Unnatural focus outline in frontend#11727
Fix: Adminbar: Unnatural focus outline in frontend#11727hbhalodia wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR. However, we cannot simply remove the outline because it is necessary in Windows High Contrast mode, as the text and background colors do not change when focused.
You can test this issue by opening the developer tools in the Chrome browser, accessing "More Tools", "Rendering", and "Emulate CSS media feature forced-colors", and changing it to "forced-colors:active".
In WordPress, transparent outlines are sometimes used to solve this type of problem. This approach takes advantage of the characteristic that transparent outlines are not visually displayed, but they become visible in Windows High Contrast Mode.
Based on this, it should be sufficient to simply make the following changes.
#wpadminbar a:focus {
outline-offset: -1px;
/* Only visible in Windows High Contrast mode */
outline: 2px solid transparent;
}
Trac ticket: https://core.trac.wordpress.org/ticket/65177
Description
Screenshots
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.