Skip to content

Replace assertEquals with assertSame for stricter checks#11707

Open
shreyasikhar wants to merge 1 commit intoWordPress:trunkfrom
shreyasikhar:ticket/64895
Open

Replace assertEquals with assertSame for stricter checks#11707
shreyasikhar wants to merge 1 commit intoWordPress:trunkfrom
shreyasikhar:ticket/64895

Conversation

@shreyasikhar
Copy link
Copy Markdown

@shreyasikhar shreyasikhar commented May 5, 2026

PR Description

  • Updates multiple PHPUnit tests to use assertSame() instead of assertEquals() to enforce strict type comparisons.
  • Adds an explicit (int) cast for post_author in the bulk edit test to avoid false positives due to string/integer mismatches.
  • Touches tests covering admin bulk edit behavior, REST API endpoints (attachments, global styles, wp-abilities), and theme preview hooks—no production/runtime code changes.

Trac ticket: https://core.trac.wordpress.org/ticket/64895


Use of AI Tools

AI assistance: Yes
Tool(s): GitHub Copilot
Used for: Find the files where assertEquals() can be replaced with assertSame().

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreyasikhar26.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant