Clean src before building to remove abandoned files#11306
Clean src before building to remove abandoned files#11306desrosj wants to merge 5 commits intoWordPress:trunkfrom
src before building to remove abandoned files#11306Conversation
cfbf05b to
b5ac8ea
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The previous attempt was creating an infinite loop.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
grunt clean to postinstall temporarilysrc before building to remove abandoned files
aaronjorbin
left a comment
There was a problem hiding this comment.
Looks and sounds good to me
|
Merged in r62069. |
This addresses an issue where files persist in the
srcdirectory of the build server checkout despite having been removed. Because the files are not under version control and there's no explicit delete command, they are not removed fromsrcas expected.Specific details about this issue can be found in this comment.
Now that
grunt cleanhas been updated to account for the new files and locations, it can be run before building to ensure a clean state (see dc20352).This is a short-term solution that's meant to run once and be removed. The long-term solution is the work being done in #11064, which will re-add these files to version control, which solves this problem naturally through changes to the files themselves.
Trac ticket: Core-64393.
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.