Skip to content

Admin reskin: Add fallback values to the CSS custom properties for the media view and button styles#11301

Open
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:64840-css-custom-property-fallback-value
Open

Admin reskin: Add fallback values to the CSS custom properties for the media view and button styles#11301
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:64840-css-custom-property-fallback-value

Conversation

@t-hamano
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/64840

Use of AI Tools

All code changes were made by Copilot, and I have verified that all changes are correct.

Testing instructions

One way to test this PR is to use Elementor. Elementor uses media modals on screens that are not enqueuing CSS custom properties.

  1. Install Elementor
  2. Open http://localhost:8889/wp-admin/post-new.php
  3. Click the " Edit with Elementor" button (If it's not enabled)
  4. Click the Image button inside the left sidebar
  5. Click the "Choose Image" button
  6. Confirm the button colors

Screenshot

Before After
image image
image image

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta
Copy link
Member

The fallback value is currently being applied to the Media View button. ✅

Before After
before-patch after-patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants