Media: Broaden DIP header to all admin and preview pages#11298
Draft
adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
Draft
Media: Broaden DIP header to all admin and preview pages#11298adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
adamsilverstein wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Send the Document-Isolation-Policy header on all admin pages and front-end preview pages instead of only specific editor screens. This keeps all admin navigations (site editor, template operations, pattern editing) and preview popups in the same agent cluster, preserving cross-window communication in Chromium 137+.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document-Isolation-Policyheader on all admin pages (viaadmin_init) instead of only 4 specific editor screens (load-post.php,load-post-new.php,load-site-editor.php,load-widgets.php)wp_set_up_cross_origin_isolation_for_preview()to send DIP on front-end preview pages (viatemplate_redirect)Why
When the editor sends the DIP header but navigated-to pages (previews, template operations, site editor sub-pages) don't, the browser places them in different agent clusters. This breaks cross-window communication (
window.opener, popup references) and currently requires 6 Gutenberg E2E test suites to disable client-side media processing entirely.Test plan
vendor/bin/phpunit tests/phpunit/tests/media/wpCrossOriginIsolation.php?action=...)