Replace the site icon fallback with a gray logo image#11293
Replace the site icon fallback with a gray logo image#11293sabernhardt wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-includes/embed.php
Outdated
| esc_url( get_site_icon_url( 32, includes_url( 'images/w-logo-gray-white-bg.png' ) ) ), | ||
| esc_url( get_site_icon_url( 64, includes_url( 'images/w-logo-gray-white-bg.png' ) ) ), |
There was a problem hiding this comment.
Should we take this as an opportunity to use the SVG logo instead? This was added to wp-admin recently: https://github.com/WordPress/wordpress-develop/blob/1afbc8ae29e1be0d466182bc74a0c5261b60a70f/src/wp-admin/images/wordpress-logo-gray.svg
There was a problem hiding this comment.
That's the image I used to create the PNG 😉
though I added a white <circle> for the background:
<circle fill="#ffffff" cx="32" cy="32" r="32"/>
Adding the (modified) SVG in wp-includes/images works when calling it in the embed template.
<img src="http://localhost/dev/src/wp-includes/images/w-logo-gray-white-bg.svg" srcset="http://localhost/dev/src/wp-includes/images/w-logo-gray-white-bg.svg 2x" width="32" height="32" alt="" class="wp-embed-site-icon">
I'm not entirely convinced it should be SVG, but if not, my last commit can be reverted to keep the PNG there.
wp-includes/images. (I started withwp-admin/images/wordpress-logo-gray.svg, added a white background, and used Adobe Illustrator to save as PNG.)do_favicon()function.Current blue logo

Gray logo

Trac 64877
Use of AI Tools: none
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.