Fix race condition in RTC default polling provider#11292
Fix race condition in RTC default polling provider#11292chriszarate wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
alecgeatches
left a comment
alecgeatches
left a comment
There was a problem hiding this comment.
The logic looks solid to me, and local smoke testing works through a lot of compaction cycles.
See also: #11067. Developed in: #11292. Fixes #64887. Props czarate, westonruter, mindctrl, peterwilsoncc, joefusco. git-svn-id: https://develop.svn.wordpress.org/trunk@62064 602fd350-edb4-49c9-b593-d223f7449a82
See also: WordPress/wordpress-develop#11067. Developed in: WordPress/wordpress-develop#11292. Fixes #64887. Props czarate, westonruter, mindctrl, peterwilsoncc, joefusco. Built from https://develop.svn.wordpress.org/trunk@62064 git-svn-id: http://core.svn.wordpress.org/trunk@61346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
mindctrl
left a comment
mindctrl
left a comment
There was a problem hiding this comment.
Thanks for opening this @chriszarate and continuing to raise awareness.
I see it was committed in https://core.trac.wordpress.org/changeset/62064 🎉
4 participants
Fix race condition in RTC default polling provider. This solution is pulled from @mindctrl's PR #11067
This PR is targeted as narrowly as possible at the solving the race condition and does not attempt to solve the cache invalidation issues. If #11290 is merged, then we can consider it solved separately.
This race condition is also solved by @josephfusco's PR #11256 to replace post meta storage with a dedicated table. If that PR is merged, this one can be closed.
Trac ticket: https://core.trac.wordpress.org/ticket/64887