Implement deterministic RAND(N) and improve unseeded RAND() translation#341
Open
wp-fuse wants to merge 2 commits intoWordPress:trunkfrom
Open
Implement deterministic RAND(N) and improve unseeded RAND() translation#341wp-fuse wants to merge 2 commits intoWordPress:trunkfrom
wp-fuse wants to merge 2 commits intoWordPress:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the MySQL-compatible
RAND()support in the AST-based SQLite driver. It replaces the previous generic implementation with a bit-exact MySQL Linear Congruential Generator (LCG) and a robust SQLite-level translation for unseeded calls.Technical Changes
rand()UDF inWP_SQLite_PDO_User_Defined_Functionsto use an instance-local LCG.0x10001,55555555,0x10000001) to ensure bit-exact deterministic output for given seeds, as requested in the previous review.mt_srand()andmt_rand()usage to prevent PHP global state pollution.WP_PDO_MySQL_On_SQLiteto use:((RANDOM() & 0x7FFFFFFFFFFFFFFF) / 9223372036854775808.0).ABS(-9223372036854775808)in SQLite and ensures an unbiased distribution in the[0, 1)range.RAND()fix from other compatibility layers. All string-replacement hacks and non-AST layers have been excluded.Validation
phpcs.