fix: Plugin "Check it!" button fails silently with nonce error #893 - #1418
Open
kmfoysal06 wants to merge 2 commits into
Open
fix: Plugin "Check it!" button fails silently with nonce error #893#1418kmfoysal06 wants to merge 2 commits into
kmfoysal06 wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tamimhasan19702, @rtpHarry. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #893
The changes in this PR are to add a custom error notice in the UI instead of showing the error in the console when an error occurs in the catch block.
Why?
The issue mentioned above shows how, after some time, when the nonce gets expired, the check plugin button does not work and shows an invalid nonce message in the console. So, the solution is either to tell the user about the nonce expiration on the client side visually or reload the page automatically. As reloading the page won't be a consistent solution, I decided to show an admin error notice informing the user that the nonce has expired.
How?
My suggested solution is to show the error message from the server side directly as an admin error notice so the user can understand why the plugin check is failing.
Testing Instructions
PLUGIN_CHECK.nonce = 'gg'and press Enter to make the nonce invalid.AI Usage Disclosure
If AI tools were used, please describe how they were used:
AI tools used in this PR only to modify the PR message to ensure no grammar mistake included in the message.
Unlinked contributors: tamimhasan19702, rtpHarry.
Co-authored-by: kmfoysal06 kmfoysal06@git.wordpress.org
Co-authored-by: iyut aralle@git.wordpress.org