fix(checker): clean up runtime on failure - #1416
Open
faisalahammad wants to merge 1 commit into
Open
Conversation
- Run the cleanup cascade in Abstract_Check_Runner::run() from a finally block so runtime tables and the object-cache drop-in are removed even when a check throws. - Add Runtime_Environment_Setup::cleanup_if_set_up() helper. - Clean up leftover runtime state on plugin deactivation. - Add uninstall.php to clean up runtime state on plugin deletion. Fixes WordPress#183
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #183
Why?
Runtime checks install a parallel WordPress database (pc_-prefixed tables) and an object-cache.php drop-in. Cleanup only ran on the happy path, so any check that threw or any request that orphaned state left those tables behind.
How?
Testing Instructions
See TESTING_INSTRUCTIONS.md in the PR diff for manual scenarios (happy path, interrupted AJAX, uninstall, CLI exception). Automated tests in tests/phpunit/tests/Checker/ and tests/phpunit/tests/Installer/.
Screenshots or screencast