fix(admin): decouple AJAX calls and remove unnecessary return values - #1415
Open
faisalahammad wants to merge 1 commit into
Open
fix(admin): decouple AJAX calls and remove unnecessary return values#1415faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
Refactor the JavaScript AJAX chain so each step takes its own parameters instead of relying on raw response data from the previous step. Remove the now-unnecessary plugin and checks keys from the set_up_environment AJAX response, and drop the array return from configure_runner.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
davidperezgar
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #131
Decouple the AJAX call chain in the JS admin so each step takes its own arguments instead of relying on raw response data from the previous step. Remove the now-unnecessary return values from the PHP endpoint.
Why?
The previous JS chain passed the full response
dataobject from one step to the next, forcing PHP endpoints to echo back values they did not own. For example,set_up_environmentreturnedpluginandchecksonly because the next step needed them. This made the flow harder to understand and maintain.How?
fetchAJAX(formData)wrapper to reduce repeated fetch boilerplate across 5 call sites.getSelectedValues(list)helper to read checked checkboxes from a NodeList.currentChecksvariable so check slugs are stored betweengetChecksToRunandrunChecks.getChecksToRun,setUpEnvironment,runChecks, andrunCheckto accept individual parameters instead of adataobject.pluginandchecksfrom theset_up_environmentresponse.configure_runner()now returnsvoid.exportResultsto use the sharedfetchAJAXwrapper.Testing Instructions
200andsuccess: true.plugin_check_set_up_environmentresponse - it should contain onlydata.message(nodata.pluginordata.checks).AI Usage Disclosure
If AI tools were used, please describe how they were used:
Used AI-assisted development tools for code suggestions and refactoring patterns.
Screenshots or screencast
No UI changes. The plugin behaves identically before and after.