Experiment to connect HTML attributes with custom fields#53514
Closed
SantosGuillamot wants to merge 3 commits intotrunkfrom
Closed
Experiment to connect HTML attributes with custom fields#53514SantosGuillamot wants to merge 3 commits intotrunkfrom
SantosGuillamot wants to merge 3 commits intotrunkfrom
Conversation
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/html-api/class-wp-html-tag-processor.php ❔ lib/compat/wordpress-6.4/html-api/class-wp-html-open-elements.php ❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor-state.php ❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php ❔ lib/experimental/blocks.php ❔ lib/experimental/connection-sources/index.php ❔ lib/load.php |
Contributor
Author
|
Closing this PR as it was just meant to be an experiment. It can always be reopened/reused in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is an experiment to explore the possibility of connecting HTML attributes with any source like meta/custom fields.
I made a video explaining it a bit deeper:
https://www.loom.com/share/ce428827a81248a297a1b9fa0b091dbc?sid=f9665430-b6c3-41f7-b873-9f852d1e619d
How?
To make it work, I incorporated the changes from this pull request in
wordpress/developbecause I wanted to use theset_inner_markupfunction. This will eventually be included in core so it is not relevant for this pull request.The important part is the logic included in the
blocks.php, that is reusing the code that connects block attributes and custom fields.Testing Instructions
data-wp-dynamic-contentattribute to any HTML tag with an object similar to:{ "html_attributes": { "inner_content": { "source": "meta_fields", "key": "custom_text" }, "href": { "source": "meta_fields", "key": "custom_link" } } }custom_textandcustom_linkcustom fields usingregister_post_metafor example.