Improve poll meter bar contrast in dark mode#6697
Open
jensfr1 wants to merge 1 commit into
Open
Conversation
The dark mode override used a faint translucent white (34% opacity) that was barely distinguishable from the track. Use the accent color (--wcfContentLink) so the filled portion is clearly visible, matching the visibility of the light mode bar. Resolves WoltLab#5925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In dark mode the poll result bar (
.pollMeterValue) was filled with afaint translucent white (
rgb(255 255 255 / 34%)), which is hard todistinguish from the underlying track. This makes it difficult to read
the relative share of votes at a glance.
This changes the dark mode fill to the accent color (
--wcfContentLink),so the filled portion is clearly visible and consistent with the
appearance of the bar in light mode.
Why
Reported in #5925 with before/after screenshots.
Notes
Single-line style change in
wcfsetup/install/files/style/ui/poll.scss.Using the
--wcfContentLinkvariable keeps the color in sync with theactive style's accent instead of hardcoding a value.