ci(ffi): packaging-path checks — triggers, lints, peer freshness, gradle smoke (V2-651 slice, V2-698) - #224
Merged
Merged
Conversation
…peer freshness, gradle smoke ffi/scripts, ffi/android and ffi/kotlin previously triggered NO workflow at all (the packaging PR shipped with zero automated signal). Adds the paths to the ffi-ci triggers plus a Linux-safe "Packaging checks" job: - bash -n on all build scripts - privacy-manifest plist syntax via python plistlib (plutil is macOS-only); guarded until the manifest PR lands - vendored bootstrap_peers.toml diffed against the pinned ant-client tag's copy -- forgetting the re-copy at a pin bump becomes a CI failure instead of stale bootstrap shipping (V2-698); guarded until the connect_default PR lands - Android gradle dependency-resolution smoke (JDK 17 + Gradle 8.9): proves the AAR's declared deps (JNA, coroutines) resolve at the pinned versions; no .so files needed All four check logics verified locally (scripts parse; #220's vendored file matches tag ant-cli-v0.2.11 upstream; #222's manifest parses; gradle resolves jna 5.14.0 + coroutines 1.8.1 on this base). Compile/AAR/R8 coverage stays tracked on V2-651. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of the CI coverage the #222 panel review flagged:
ffi/scripts/**,ffi/android/**andffi/kotlin/**triggered no workflow at all, so packaging changes shipped with zero automated signal.What's added
Trigger paths extended + one new Linux-safe Packaging checks job:
bash -non every build script.plistlib(plutilis macOS-only). Guarded no-op until fix(packaging): iOS privacy manifest, JNA ≥5.15, plist version truth (V2-642, V2-652) #222 lands the manifest.ffi/rust/ant-ffi/resources/bootstrap_peers.tomlagainst the same file at the pinned ant-client tag (read live fromCargo.toml) — so forgetting the re-copy at a pin bump becomes a CI failure instead of stale bootstrap silently shipping to production apps. Guarded no-op until feat(ffi): production connect_default* + data_dir connect arg (V2-637, V2-643) #220 lands the vendored file..soneeded): proves the AAR's declared deps actually resolve at the pinned versions — this would have validated fix(packaging): iOS privacy manifest, JNA ≥5.15, plist version truth (V2-642, V2-652) #222's JNA bump automatically.Verified locally
All four check logics proven on this machine before pushing: scripts parse; #220's vendored file diffs clean against
ant-cli-v0.2.11's upstream copy; #222's manifest parses via plistlib; gradle resolvesjna:5.14.0+coroutines:1.8.1on this base. This PR also modifies the workflow file itself, so the new job runs live on this PR.Scope notes
Holding merge pending review + Nic's go-ahead (no conflicts with #219–#223 — workflow file only).
🤖 Generated with Claude Code