Simple refactoring to allow customization of field/widget as_dict().#16
Open
ikatson wants to merge 1 commit intoWiserTogether:masterfrom
Open
Simple refactoring to allow customization of field/widget as_dict().#16ikatson wants to merge 1 commit intoWiserTogether:masterfrom
ikatson wants to merge 1 commit intoWiserTogether:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. my use-case is that ModelChoiceFields sometimes have too many choices, and I don't want to put them into the RemoteForm.as_dict(). There was no other way to do that other modifying the source.
Now it's a lot more flexible, you can subclass the RemoteForm and RemoteField to control the fields and widget classes that are returned.