Open
Conversation
This is written by claude sonnet
…factories and not require exaustively knowing C++ types. Claude sonnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an "app" to dump information about component types to JSON. It mostly adds new code. The changes in NamedFactory are to add a new global registry of factories so that the SchemaDumper can walk the global set.
This code is written by claude sonnet following a design I've had in mind for a while.
The end goal of this is to use the JSON dump to generate Jsonnet functions to use as constructors for config object instances for each type of component with some default config and type checking. The input/output port type info in the dump can also be used to check for correct edge connections at the Jsonnet level before ever touching C++.