Open
Conversation
Merged
…s lets pnodes be 'used by' other pnodes
CHANGE from using FrameSplitter to FrameFanout. This is done because apparently TbbFlow does not yet have a wrapper for FrameSplitter. This change SHOULD be innocuous. ADD a new depo set version of the older per-depo simulation subgraph construction. This exposes a new `signal_sets` which is like `signal` but the edges transfer depo sets instead of single depos. This is done to avoid the "Pgrapher slowdown" problem. We should probably make this new `signal_sets` be default by naming it `signal`.
Member
Author
|
Comment to mark that last commit touches MicroBooNE configuration. It should not change existing jobs but we had best apply a careful test. Let's bake that test into a BATS file. I believe we should make new |
brettviren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects changes needed to produce live+dead tiling, live+dead depo blob fill and live charge solving data for GNN training.
Things this PR provides (needs to provide)
ClusterFaninThis PR is developed top of #193 so that PR needs merging first.