Draft
Conversation
Member
|
Thanks @brettviren for the nice documentation and example. Looks really great! I will try it out and get some experience for discussion tomorrow. |
Refactor AnodePlane, only 44 more to go...
May use C-bindings to Go jsonnet via './wcb --with-jsonnet-libs=gojsonnet [...]'
Drop C++ jsonnet API and use plain C (or Go + C-bindings)
Fix #109. Adds back multithreading.
This has been with us for a while but would be rare to hit. - job must run TbbFlow instead of Pgrapher - just have more than one AnodePlane - two threads must both request spectrum() for the same wire - at the same time - and both be the first time requested There are still other races of this type though maybe all in "service" type components that are only used from one "node" component.
…on HDF5 to remove illegal cross dependency on hio
… the anode plane Note, this is a broken concept in general and will only work accidentally with some detectors.
There is a stand-alone PlaneSelector to do this and DNNROIFinding changes from cbeg/cend to using the same pattern internally. This is based on a channel selection from OmnibusSigProc that is moved into a new Aux/PlaneTools.h. But, OmnibusSigProc still is left as-is. It should be factored to use this moved code.
…ut scale is used in dnnroi
Prepare for hybrid full chain with wc/ls stage separate from follow-on pure-WCT stage
Refactor AnodePlane, only 44 more to go...
…figurable base class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the start of a more formal handling of configuration using schema and code generation to address some long-standing design omissions.
See the util/schema/README.org for more motivations and details.
In principle, we can merge this any time and then make adiabatic progress by converting each component one-by-one. But, before doing that, I think the rest of the team needs to be okay with it. So, we can keep this as a "draft PR" for a while.
As a start, @HaiwangYu please take a look and we can discuss what next steps are best.