DressUp: Directory Comparison and Case-Sensitivity Fixes#2544
Open
voliathon wants to merge 1 commit into
Open
Conversation
Fixes an issue where profile loading and file comparisons fail on systems/configurations with mismatching folder path casing
voliathon
changed the title
voliathon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fixes an issue where profile loading and file comparisons fail on systems/configurations with mismatching folder path casing. By enforcing case insensitivity during the string comparisons against .lua data databases, we ensure robust cross-platform/case-insensitive behavior when the client parses profiles and gear databases.
Importance: Prevents silent failures when trying to load gear configurations (such as user profile definitions matching [gear].lua), guaranteeing consistent operation regardless of how directory paths or filenames are capitalized.
Previous //du self main Apocalypse would fail due to mismatch and not be recognized. The 'Apocalypse' in this fix would be lowercased and whatever the user entered would be lowercased regardless of case allowing for dressup to display the weapon.
Without this fix, changing gear in dressup will continue to fail.