fix mob spawning

[kalibrieren]

couldn't even find this patch on Taco's repo, wtf is this?

[kalibrieren]

changing SpawnerCreature#getEntityCount to using Spigot's original way of doing it has a significant performance impact with the server lagging more

[windcolor-dev]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?

I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

[kalibrieren]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?

I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

I believe using the whole world isn't very useful for multiplayer servers. Spigot probably used only loaded chunks because of that.
I noticed monster spawning to be way less (basically none) in my Spigot - and I think WindSpigot is affected here aswell because of this patch.

[windcolor-dev]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?
I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

I believe using the whole world isn't very useful for multiplayer servers. Spigot probably used only loaded chunks because of that. I noticed monster spawning to be way less (basically none) in my Spigot - and I think WindSpigot is affected here aswell because of this patch.

I see. Maybe it would be best to make this configurable? So we don't break vanilla expectations

[kalibrieren]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?
I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

I believe using the whole world isn't very useful for multiplayer servers. Spigot probably used only loaded chunks because of that. I noticed monster spawning to be way less (basically none) in my Spigot - and I think WindSpigot is affected here aswell because of this patch.

I see. Maybe it would be best to make this configurable? So we don't break vanilla expectations

I guess, but best to search for a performance improvement before that.

[kalibrieren]

We forgot 17x17 at moblimit, this fixes it. Also renamed TacoSpigot -> PandaSpigot as the patch is easier to locate there (Taco's is non-existent?)

[windcolor-dev]

Have you tested mob spawning to work as expected with these fixes?

[kalibrieren]

Have you tested mob spawning to work as expected with these fixes?

No, but should work better with this fix as we forgot 17x17 at moblimit.

[windcolor-dev]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?
I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

I believe using the whole world isn't very useful for multiplayer servers. Spigot probably used only loaded chunks because of that. I noticed monster spawning to be way less (basically none) in my Spigot - and I think WindSpigot is affected here aswell because of this patch.

I see. Maybe it would be best to make this configurable? So we don't break vanilla expectations

I guess, but best to search for a performance improvement before that.

Could you test it out a bit? I don't use mob spawning much on my servers, so I'm unfamiliar with the issue, I think you would have a better idea of whether it's fixed or not.

[kalibrieren]

Can you elaborate a bit more? Isn't it vanilla behavior to use the whole world instead of just loaded chunks?
I believe this was a backported paper patch, I believe PandaSpigot also has it. https://github.com/hpfxd/PandaSpigot/blob/master/patches/server/0072-Fix-Bugs-with-Spigot-Mob-Spawn-Logic.patch

I believe using the whole world isn't very useful for multiplayer servers. Spigot probably used only loaded chunks because of that. I noticed monster spawning to be way less (basically none) in my Spigot - and I think WindSpigot is affected here aswell because of this patch.

I see. Maybe it would be best to make this configurable? So we don't break vanilla expectations

I guess, but best to search for a performance improvement before that.

Could you test it out a bit? I don't use mob spawning much on my servers, so I'm unfamiliar with the issue, I think you would have a better idea of whether it's fixed or not.

Can't really test it now aswell, but I can also do another PR that removes the tick limiters which cleans up the config a bunch and just makes the code a bit simpler - tick limiters can also block spawning and there's a negligible performance impact - tick limiters were removed in FalchusSpigot aswell.

[windcolor-dev]

Sounds good. Thanks again for all your contributions, they've been really helpful

[kalibrieren]

Sounds good. Thanks again for all your contributions, they've been really helpful

#143