Fix dangling symlink summary label - #5153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output.Skippedidentifier in human full-index dangling-symlink summaries with the user-facingskippedlabelValidation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-restore --filter FullyQualifiedName~Run_DryRunAndFullScan_ClassifyDanglingSymlinkAsWarningAndUseHumanSkippedLabel_Issue4829_Issue5139(net8.0 and net9.0 passed)dotnet build CodeIndex.sln -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-restore(passed with 0 warnings and 0 errors)dotnet test CodeIndex.sln -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-build --no-restore(net9.0: 11,280 passed / 423 skipped; net8.0: 11,758 passed / 7 skipped with one transient unrelated Git timeout fixture failure, whose exact isolated retry passed)dotnet run --project tools/CodeIndex.Changelog -c Release --no-build -- check(45 fragments validated)status --checkand workspace manifest health checks passed after commit-index refreshDocumentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.mdin both English and Japanese sectionschangelog.d/unreleased/5139.fixed.mdReview
No blocking/actionable issues found.Follow-up candidates
Fixes #5139