Skip to content

Fix dangling symlink summary label - #5153

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue5139
Aug 22, 2026
Merged

Fix dangling symlink summary label#5153
Widthdom merged 1 commit into
mainfrom
fix-issue5139

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • replace the leaked output.Skipped identifier in human full-index dangling-symlink summaries with the user-facing skipped label
  • extend the existing dangling-symlink fixture to cover human output while preserving its dry-run and JSON assertions
  • synchronize the English/Japanese developer and testing contracts

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-restore --filter FullyQualifiedName~Run_DryRunAndFullScan_ClassifyDanglingSymlinkAsWarningAndUseHumanSkippedLabel_Issue4829_Issue5139 (net8.0 and net9.0 passed)
  • dotnet build CodeIndex.sln -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-restore (passed with 0 warnings and 0 errors)
  • dotnet test CodeIndex.sln -c Release -m:1 -nr:false -p:BuildInParallel=false -p:UseSharedCompilation=false --no-build --no-restore (net9.0: 11,280 passed / 423 skipped; net8.0: 11,758 passed / 7 skipped with one transient unrelated Git timeout fixture failure, whose exact isolated retry passed)
  • dotnet run --project tools/CodeIndex.Changelog -c Release --no-build -- check (45 fragments validated)
  • root status --check and workspace manifest health checks passed after commit-index refresh

Documentation and changelog

  • updated DEVELOPER_GUIDE.md and TESTING_GUIDE.md in both English and Japanese sections
  • added changelog.d/unreleased/5139.fixed.md

Review

  • Codex adversarial review: No blocking/actionable issues found.

Follow-up candidates

  • None.

Fixes #5139

@Widthdom
Widthdom merged commit 294f4da into main Aug 22, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue5139 branch August 22, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix literal output.Skipped text in dangling-symlink summary

1 participant