Skip to content

Reject invalid index numeric options - #5134

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue5097
Aug 21, 2026
Merged

Reject invalid index numeric options#5134
Widthdom merged 4 commits into
mainfrom
fix-issue5097

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Reject invalid explicit numeric index options with structured E010_USAGE_ERROR output before database setup or worker startup.
  • Keep compatible environment fallback/clamping for indexing paths while reporting the environment source and effective value in human and JSON warnings.
  • Suppress those fallback warnings in --optimize mode, where the numeric indexing settings are not consumed.
  • Document the inclusive ranges and fallback policy, and add boundary, provenance, duplicate, no-mutation, output-contract, and watch JSON coverage.

Validation

  • dotnet restore CodeIndex.sln
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore (0 warnings, 0 errors)
  • Full Release tests: .NET 8 — 9,013 passed, 6 skipped; .NET 9 isolated rerun — 11,239 passed, 423 skipped, 0 failed after the concurrent test host process exited unexpectedly
  • Issue-focused tests after the final review fix: .NET 8/9 — 77 passed per target, 0 failed
  • Ambient-environment isolation and watch JSON contract tests: .NET 8/9 — 3 passed per target, 0 failed
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • git diff --check
  • Root index check and workspace status: healthy, 2/2 members ready
  • Codex adversarial review: two review loops completed; all four P2 findings were fixed and the final optimize JSON reproduction was rechecked without an unstructured warning

Documentation and changelog

  • Updated the English and Japanese indexing contracts in DEVELOPER_GUIDE.md and TESTING_GUIDE.md.
  • Updated generated CLI help range/fallback descriptions.
  • Added bilingual fragment changelog.d/unreleased/5097.fixed.md.

Fixes #5097

Follow-up candidates

  • None.

@Widthdom
Widthdom marked this pull request as ready for review August 21, 2026 04:31
@Widthdom
Widthdom merged commit 2671f01 into main Aug 21, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue5097 branch August 21, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject invalid explicit index numeric options instead of silently falling back

1 participant