[GST] webkitwebsrc : Ensure minimum queue high watermark for small files - #1720
Open
asurdej-comcast wants to merge 1 commit into
Open
Conversation
Current logic allows downloading of files smaller than 2MB in single request. Everything above that is subject to high/low watermarks that is 2% and 0.4% of file size. For files just above 2MB limit the high watermark is just 50kb that results with frequent pause/resume cycles. Make sure that high watermark is not less than 2MB
Author
|
Possibly we should also consider maximum queue size, current 2% for really big files, like 200GB, would be 2GB in memory buffer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current logic allows downloading of files smaller than 2MB in single request. Everything above that is subject to high/low watermarks that is 2% and 0.4% of file size. For files just above 2MB limit the high watermark is just above 40kb that results with frequent pause/resume cycles.
Make sure that high watermark is not less than 2MB
7522e66