Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a statically linked telemetry backend path to the MessageControl plugin, forwarding TELEMETRY-type messages to a T2 (or mock) telemetry implementation (noting the PR depends on Thunder/Thunder#2090).
Changes:
- Introduces a
TelemetryBackend_*C interface and a T2-based backend implementation (with optional mock/stub builds). - Updates MessageControl publishing APIs to forward typed
Core::Messaging::IEventobjects (preserving telemetry value types). - Adds build/config switches and CI wiring to enable the T2 telemetry backend and mock library.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TelemetryBackendT2/TelemetryBackendT2.cpp | Implements the telemetry backend adapter over the T2 API (or stub). |
| TelemetryBackendT2/CMakeLists.txt | Adds build logic to link real T2, use mock, or compile in stub mode. |
| TelemetryBackendT2/mock/t2_mock.c | Provides a stdout-printing mock implementation of the T2 API. |
| TelemetryBackendT2/mock/CMakeLists.txt | Builds/installs the mock t2 shared library target. |
| MessageControl/TelemetryOutput.h | Adds the backend C interface used by MessageControl. |
| MessageControl/MessageOutput.h | Changes publisher interface to IEvent and adds TelemetryOutput publisher. |
| MessageControl/MessageOutput.cpp | Updates publisher implementations to use event.Data() via the new interface. |
| MessageControl/MessageControl.h | Updates callback/message flow to forward IEvent and adds telemetry factory member. |
| MessageControl/MessageControl.cpp | Registers telemetry factory; configures/tears down telemetry backend when enabled. |
| MessageControl/MessageControl.conf.in | Adds telemetryconfig to generated config when telemetry is enabled. |
| MessageControl/CMakeLists.txt | Adds build option to enable telemetry backend and link TelemetryBackendT2. |
| .github/workflows/Linux build template.yml | Enables telemetry backend and mock in the Linux CI build template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It needs this PR to be merged first