Tweak NewsSite test step scenarios#454
Conversation
|
I'm not opposed to this change in general. @flashdesignory what's your take here? |
|
btw, you can use crossbench to create browser comparison data easily. |
|
Hi @camillobruni, thanks for your comments. Below are the crossbench results for this PR from 10 runs. We ran the whole benchmark and extracted the scores for NewsSite cases. this PR main System and browser version Basically, NewsSite-Next runs slower while NewsSite-Nuxt runs faster. This difference is related to how each framework handles In NewsSite-Nuxt, the Vue router leverages microtasks for its navigation mechanism, so a forced layout of a new tab does not happen synchronously. However, in NewsSite-Next, |
|
Hi @camillobruni, Just kindly ping :) Do you have any comments or suggestions on this idea? Thank you! |
|
Could you try kicking off the try-jobs again? |
3d2f487 to
1411d4a
Compare
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @camillobruni, I just did a rebase and triggered a new round of CI runs. |
camillobruni
left a comment
There was a problem hiding this comment.
LGTM from my side, slightly more complexity than the original workload SGTM.
1411d4a to
967f955
Compare
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @camillobruni, thanks for the review! I just rebased the PR onto ToT. Do you think we need an additional pair of eyes on this PR? If so, could you please help invite someone you think would be appropriate? Feel free to let me know if any changes are required. |
This proof of concept illustrates potential tweaks to the test steps for the NewsSite workload. It introduces an extra navigation to a new tab instead of repeatedly toggling the drop-down menu.