Conversation
jgaleotti
requested changes
Mar 26, 2026
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisExecutionsDto.java
Show resolved
Hide resolved
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisFailedCommand.java
Show resolved
Hide resolved
...rg/evomaster/client/java/controller/api/dto/database/operations/RedisDatabaseCommandDto.java
Outdated
Show resolved
Hide resolved
...java/org/evomaster/client/java/controller/api/dto/database/operations/RedisInsertionDto.java
Show resolved
Hide resolved
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisFailedCommand.java
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/redis/RedisDbActionTransformer.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/redis/RedisInsertBuilder.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/remote/service/RemoteControllerImplementation.kt
Outdated
Show resolved
Hide resolved
jgaleotti
requested changes
Mar 30, 2026
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisExecutionsDto.java
Show resolved
Hide resolved
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisFailedCommand.java
Show resolved
Hide resolved
...ava/controller/src/main/java/org/evomaster/client/java/controller/internal/EMController.java
Outdated
Show resolved
Hide resolved
...t-java/controller/src/main/java/org/evomaster/client/java/controller/redis/dsl/RedisDsl.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @return a list of DTOs representing all the insertion Redis commands defined in this DSL. | ||
| */ | ||
| List<RedisInsertionDto> dtos(); |
Collaborator
There was a problem hiding this comment.
Should dtos() be removed?
...ontroller/src/main/java/org/evomaster/client/java/controller/redis/RedisCommandExecutor.java
Show resolved
Hide resolved
...ler/src/main/java/org/evomaster/client/java/controller/redis/ReflectionBasedRedisClient.java
Outdated
Show resolved
Hide resolved
jgaleotti
approved these changes
Mar 31, 2026
Collaborator
|
@arcuri82 you might review this PR now. |
arcuri82
requested changes
Apr 9, 2026
...java/org/evomaster/client/java/controller/api/dto/database/execution/RedisFailedCommand.java
Outdated
Show resolved
Hide resolved
...oller/src/main/java/org/evomaster/client/java/controller/internal/db/redis/RedisHandler.java
Outdated
Show resolved
Hide resolved
| serverController.setExecutingInitMongo(executingInitRedis); | ||
| // sync executingInitMongo on the local ExecutionTracer | ||
| ExecutionTracer.setExecutingInitMongo(executingInitRedis); | ||
| } |
Collaborator
There was a problem hiding this comment.
why are those functions calling *InitMongo? is it a copy&paste bug? and if so, why no test case failed?
Collaborator
There was a problem hiding this comment.
Sorry I missed these copy-paste errors in my review. And yes, there should be a test failing due to this.
Collaborator
Author
There was a problem hiding this comment.
I apologize for this copy paste error, already changed the code. Since we do not generate heuristics on insertion commands, this didn't affect the logic for Redis data generation.
As for a new test for this code... I don't believe it's possible to test this in an e2e context or even an integration one without adding some debug methods to access the data for testing.
...2etests/spring/rest/redis/lettuce/findkeynosave/findkey/RedisLettuceFindKeyNoSaveEMTest.java
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/output/service/ApiTestCaseWriter.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/output/service/ApiTestCaseWriter.kt
Outdated
Show resolved
Hide resolved
arcuri82
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Redis execution info extraction and data generation (only for GET command).
RedisActions are now included, and new data is being inserted into Redis. Test cases also include Redis new data using RedisDsl and a RedisWriter.