Skip to content

deprecate(#122): mark WebServicesManager as deprecated#130

Merged
usernane merged 1 commit into
devfrom
refactor/122-deprecate-web-services-manager
Jun 1, 2026
Merged

deprecate(#122): mark WebServicesManager as deprecated#130
usernane merged 1 commit into
devfrom
refactor/122-deprecate-web-services-manager

Conversation

@usernane

@usernane usernane commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

Mark WebServicesManager as deprecated, completing the ADR-0005 refactoring chain. Step 5 of 5.

Motivation

With RequestProcessor, ErrorResponse, and OpenAPIGenerator in place, WebServicesManager is now a legacy wrapper. New code should use RequestProcessor directly. Fixes #122.

Changes

  • Added @deprecated to WebServicesManager class docblock with migration guide
  • Added @deprecated to process() and sendResponse() methods
  • Updated README Quick Start to show RequestProcessor as the recommended approach
  • Registry methods (addService, getServices, etc.) remain undeprecated for backward compat

UI Changes

N/A

How to Test / Verify

php vendor/bin/phpunit tests/

530 tests pass unchanged — full backward compatibility.

Breaking Changes and Migration Steps

None. All existing code continues to work. Deprecation annotations guide migration:

// Before:
$manager = new WebServicesManager();
$manager->addService(new MyService());
$manager->process();

// After:
$processor = new RequestProcessor();
$processor->process(new MyService());

Checklist

  • I reviewed my own diff before requesting review
  • My commits follow Conventional Commits
  • The title of the pull request follows Conventional Commits
  • I added/updated tests (or explained why not)
  • I updated docs (if needed)
  • I ran lint/cs-fixer (if applicable)
  • I considered backward compatibility
  • I considered security

Related issues

Closes #122
Completes ADR-0005: https://github.com/WebFiori/docs/blob/main/adr/0005-request-processor-replaces-manager.md

- Add @deprecated to class docblock with migration guide to RequestProcessor
- Add @deprecated to process() and sendResponse() methods
- Update README Quick Start to show RequestProcessor as primary approach
- All existing tests pass unchanged (full backward compatibility)
- Step 5 of 5 in ADR-0005 (RequestProcessor refactor) — COMPLETE
@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

@usernane usernane merged commit c247e83 into dev Jun 1, 2026
3 checks passed
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.64%. Comparing base (7810da5) to head (489b2d0).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #130   +/-   ##
=========================================
  Coverage     93.64%   93.64%           
  Complexity     1316     1316           
=========================================
  Files            39       39           
  Lines          3180     3180           
=========================================
  Hits           2978     2978           
  Misses          202      202           
Flag Coverage Δ
php-8.3 93.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant